Skip to content

docs: Native Stack - headerBackButtonMenuEnabled #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

stanleyoos
Copy link
Contributor

@stanleyoos stanleyoos commented Aug 1, 2024

React Navigation, Native Stack, v7.x

  • added screenshots for: headerBackTitle, headerBackTitleStyle, headerBackButtonMenuEnabled

@stanleyoos stanleyoos self-assigned this Aug 1, 2024
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for react-navigation-docs ready!

Name Link
🔨 Latest commit 1398417
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-docs/deploys/66acb39a42cf770008893803
😎 Deploy Preview https://deploy-preview-1352--react-navigation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stanleyoos stanleyoos changed the title chore(docs): Added sample videos and screenshots - Native Stack chore: Native Stack doc's - headerBackButtonMenuEnabled Aug 2, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary to split these files into separate folder, even worse having a separate folder for a singular image eg. headerBackTitle/headerBackTitle.jpeg. A better approach is to have it all in a single native-stack folder and using names for files that group them well.

@stanleyoos stanleyoos marked this pull request as ready for review August 2, 2024 09:56
Comment on lines 205 to 222
export function NativeStack() {
return (
<Stack.Navigator>
<Stack.Screen
name="NewsFeed"
component={NewsFeedScreen}
options={{
title: 'Feed',
headerBackTitle: 'Back title example',
headerBackTitleStyle: {
fontSize: 14,
fontFamily: 'Georgia',
},
}}
/>
</Stack.Navigator>
);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to put a full example here you'd also have to add Static API (your example is in Dynamic API) see https://reactnavigation.org/docs/7.x/native-stack-navigator#usage for reference

Here. maybe a simpler example would also work just fine?

Suggested change
export function NativeStack() {
return (
<Stack.Navigator>
<Stack.Screen
name="NewsFeed"
component={NewsFeedScreen}
options={{
title: 'Feed',
headerBackTitle: 'Back title example',
headerBackTitleStyle: {
fontSize: 14,
fontFamily: 'Georgia',
},
}}
/>
</Stack.Navigator>
);
}
headerBackTitleStyle: {
fontSize: 14,
fontFamily: 'Georgia',
},

Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@stanleyoos stanleyoos merged commit 89cc4b8 into main Aug 5, 2024
3 checks passed
@stanleyoos stanleyoos deleted the @stanleyoos/chore-docs-native-stack-headerBackButtonMenuEnabled branch August 5, 2024 10:42
@stanleyoos stanleyoos changed the title chore: Native Stack doc's - headerBackButtonMenuEnabled docs: Native Stack - headerBackButtonMenuEnabled Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants